https://gitlab.synchro.net/main/sbbs/-/commit/a2a1448caeaf2b1a6add92e8
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Play this game.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a6efc1beffc68abb0f64e23e
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Merge remote-tracking branch 'origin/master'

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/4e9ff218de9f9656b2451ae5
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Fix apparent memory leak in js_listening_socket_constructor()

The socket set allocated by xpms_create() was never freed. Found by Coverity.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ec7f57ab985273580f085bbb
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Close Socket on unhandled TLS errors

While errors on transmit seem to be handled well, errors on receive
do not, especially through js_recv_line() which has been seen to
trigger a large number (hundreds) of ECONNRESET errors. To prevent
this, simply close the socket when an otherwise unhandled error
occurs.

Almost certainly fixes that issue, but the underlying cause is still undetermined. The calling script (imapservice.js) was checking Socket.is_connected after each recv_line() call, so if the socket
was actually reset, it would be expected to only call it once.

An alternative would be to explicitly handle the error that is
seen (CRYPT_ERROR_PARAM1), but let's try a generic fix first and see
of anything breaks because of it. Most likely issue would be an
inability to recv() data after calling shutdown(), but I don't think
many people do that except to move the TIME_WAIT to where they want
it.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/8eaa996b9092487ed67eb428
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Fix Socket.connect()

Broken with the poll() update

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/4d23eff969882b00474af389
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Fix resource leaks caught by Coverity-scan

CID 330950 and 319020

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/8e9b1273d3b896afc02f6180
Modified Files:
src/sbbs3/js_socket.c
Log Message:
printf fmt/argument type mismatches

CID 319085 319089 319135 319142

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7a8b54b954b6d0fbce888961
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Fix some bugs around sock.on('write'...) and sock.clearOn()

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/4a50048e71c7c6d958acd428
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Fix invalid type in argument to printf format specifier

CID 319135

Fix the return value of js_socket_sendfilesocket() while we're here (off_t instead of int).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f0127e9d4572f8c1c44536dc
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Check socket writability in JS Socket.send()

BINKP is suddenly frequently hanging on sendsocket() on Vertrauen on Windows (sending files to my Z1 hub) so try this as a solution.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3389aadcb8d3bcc3b428b993
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Revert "Check socket writability in JS Socket.send()"

This reverts commit f0127e9d4572f8c1c44536dcda240c310e18f7d8.

This change was "wrong-headed" per Deuce and broke JS sends on
blocking sockets. Thanks for the help.

This fix for inifinite-wait on send() likely led to the infinite
BinkIT errors/log messages that led to commit 4dd32231.

The real fix for this problem (which can block all other timed
events from running), would be a Socket.poll() on the socket before
send in binkp.js.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ab4eca0e22c1c318db48edf6
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Fix misplaced JS_RESUMEREQUEST() - do thise *before* potential return

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/52d9a03d372792616091e4c6
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Apply socket options from sockopts.ini to sockets created by ListeningSocket()

This socket constructor did not get the global socket options treatment when created (years ago).

This should fix issue #402 as reported by Nelgin and more recently by Keyop.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7ff687ff15f690410daa0bdb
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Revert "Apply socket options from sockopts.ini to sockets created by ListeningSocket()"

This reverts commit 52d9a03d372792616091e4c66b28d98d711d3b29.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/99e8c77caf4a718768e80e6a
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Revert "Revert "Apply socket options from sockopts.ini to sockets created by ListeningSocket()""

This reverts commit 7ff687ff15f690410daa0bdbe2ecc468ea1b4a41.

We're already passing a sock_init callback (ls_cb) which is supposed to set
the socket options (call set_socket_options), so this change shouldn't be necessary and reportedly caused more issues binding ircd sockets when running ircd.js via jsexec (though I didn't see this myself).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f9a44f56e2ad13a4373e63cd
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Manual revert of the ListeningSocket contructor "fix" which wasn't necessary

I keep reverting/un-reverting the merge that includes an unrelated logon.cpp change. So just manually remove this new code that was added to attempt to
fix issue #402 since I incorrectly concluded that sockopts.ini wasn't being applied to new sockets created with ListeningSocket().

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f07baf44425fdbee1059e2e5
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Fix return value when p->peeked is true

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/72d7a4904ccc668abc4dc3f5
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Merge branch 'Ree/js_socket_recv-fix' into 'master'

Fix return value when p->peeked is true

See merge request main/sbbs!328

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2baafdb0f202ef1367fe6794
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Limit JS Socket TLS error levels to "warning" severity

Ideally, this would use startup.tls_error_level, but which one? And how?

Also, make a TODO comment to fix the fact that all JS Socket log messages
are logged to the terminal server log output. :-(

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f71b2650467aa655a44271ea
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Improve JS error reporting

Include function names. Include host:port in "Unable to connect" error.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/13b07dbad2c77cef9f9f0aaf
Modified Files:
src/sbbs3/js_socket.c
Log Message:
__FUNCTION__ is not a string constant in GCC, so can't do this

error: expected `)' before string constant

Harumph.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c9cb9c9cf9511b0f0ba29008
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Fix invalid pointer type waring (and bug)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6aa310dfee947380e7513b35
Modified Files:
src/sbbs3/js_socket.c
Log Message:
get scfg from runtime before syncing cert

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/242d088a8b7f6d2baa3c7569
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Ugh, spaces instead of tabs... so gross.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/bebd0b64c36bccbc3f5d5cef
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Only tls servers should call destroy_session()

TLS clients don't (currently) add a certificate, so there's no need
to delete it.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e67f51d0eaf484d995ade630
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Document the connect() callback thing.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f1cdaea3b87caa96bbf9b8c6
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Don't check recvline() timeout *before* checking if there's data to receive

This was a regression: Socket.recvline() used to not care what the timeout duration was so long as there were bytes to receive.

Also, remove the ".0" from timeout values in documented mehtods that don't
(any longer) accept floating point timeout durations. We used to support fractional seconds for some of these methods, and that was implied by using
the floating point default values, but that's no longer the case. poll()
still accepts a floating point timeout.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f4ea0c75823aafb6fa3d9da8
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Document return values of Socket.poll()

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net